[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58363: [PATCH 2/3] Introduce a new sqlite-error
From: |
Jonas Bernoulli |
Subject: |
bug#58363: [PATCH 2/3] Introduce a new sqlite-error |
Date: |
Fri, 21 Oct 2022 23:06:35 +0200 |
* src/sqlite.c (check_sqlite, sqlite-open, bind_values)
(sqlite-execute, sqlite-select, sqlite-load-extension)
(sqlite-next): Use it.
(syms_of_sqlite): Introduce a new error for all sqlite errors
so that we can catch that condition on higher levels.
---
src/sqlite.c | 34 ++++++++++++++++++++--------------
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/src/sqlite.c b/src/sqlite.c
index 7861a699f4..78b261fb08 100644
--- a/src/sqlite.c
+++ b/src/sqlite.c
@@ -233,13 +233,13 @@ check_sqlite (Lisp_Object db, bool is_statement)
init_sqlite_functions ();
CHECK_SQLITE (db);
if (is_statement && !XSQLITE (db)->is_statement)
- xsignal1 (Qerror, build_string ("Invalid set object"));
+ xsignal1 (Qsqlite_error, build_string ("Invalid set object"));
else if (!is_statement && XSQLITE (db)->is_statement)
- xsignal1 (Qerror, build_string ("Invalid database object"));
+ xsignal1 (Qsqlite_error, build_string ("Invalid database object"));
if (!is_statement && !XSQLITE (db)->db)
- xsignal1 (Qerror, build_string ("Database closed"));
+ xsignal1 (Qsqlite_error, build_string ("Database closed"));
else if (is_statement && !XSQLITE (db)->db)
- xsignal1 (Qerror, build_string ("Statement closed"));
+ xsignal1 (Qsqlite_error, build_string ("Statement closed"));
}
static int db_count = 0;
@@ -259,7 +259,7 @@ DEFUN ("sqlite-open", Fsqlite_open, Ssqlite_open, 0, 1, 0,
#endif
if (!init_sqlite_functions ())
- xsignal1 (Qerror, build_string ("sqlite support is not available"));
+ xsignal1 (Qsqlite_error, build_string ("sqlite support is not available"));
if (!NILP (file))
name = ENCODE_FILE (Fexpand_file_name (file, Qnil));
@@ -272,7 +272,7 @@ DEFUN ("sqlite-open", Fsqlite_open, Ssqlite_open, 0, 1, 0,
name = CALLN (Fformat, memory_fmt, make_int (++db_count));
flags |= SQLITE_OPEN_MEMORY;
#else
- xsignal1 (Qerror, build_string ("sqlite in-memory is not available"));
+ xsignal1 (Qsqlite_error, build_string ("sqlite in-memory is not
available"));
#endif
}
@@ -342,7 +342,7 @@ bind_values (sqlite3 *db, sqlite3_stmt *stmt, Lisp_Object
values)
if (blob)
{
if (SBYTES (value) != SCHARS (value))
- xsignal1 (Qerror, build_string ("BLOB values must be unibyte"));
+ xsignal1 (Qsqlite_error, build_string ("BLOB values must be
unibyte"));
ret = sqlite3_bind_blob (stmt, i + 1,
SSDATA (value), SBYTES (value),
NULL);
@@ -447,7 +447,7 @@ DEFUN ("sqlite-execute", Fsqlite_execute, Ssqlite_execute,
2, 3, 0,
check_sqlite (db, false);
CHECK_STRING (query);
if (!(NILP (values) || CONSP (values) || VECTORP (values)))
- xsignal1 (Qerror, build_string ("VALUES must be a list or a vector"));
+ xsignal1 (Qsqlite_error, build_string ("VALUES must be a list or a
vector"));
sqlite3 *sdb = XSQLITE (db)->db;
Lisp_Object errmsg = Qnil,
@@ -505,7 +505,7 @@ DEFUN ("sqlite-execute", Fsqlite_execute, Ssqlite_execute,
2, 3, 0,
exit:
sqlite3_finalize (stmt);
xsignal1 (ret == SQLITE_LOCKED || ret == SQLITE_BUSY?
- Qsqlite_locked_error: Qerror,
+ Qsqlite_locked_error: Qsqlite_error,
errmsg);
}
@@ -540,7 +540,7 @@ DEFUN ("sqlite-select", Fsqlite_select, Ssqlite_select, 2,
4, 0,
CHECK_STRING (query);
if (!(NILP (values) || CONSP (values) || VECTORP (values)))
- xsignal1 (Qerror, build_string ("VALUES must be a list or a vector"));
+ xsignal1 (Qsqlite_error, build_string ("VALUES must be a list or a
vector"));
sqlite3 *sdb = XSQLITE (db)->db;
Lisp_Object retval = Qnil, errmsg = Qnil,
@@ -589,7 +589,7 @@ DEFUN ("sqlite-select", Fsqlite_select, Ssqlite_select, 2,
4, 0,
exit:
if (! NILP (errmsg))
- xsignal1 (Qerror, errmsg);
+ xsignal1 (Qsqlite_error, errmsg);
return retval;
}
@@ -675,7 +675,7 @@ DEFUN ("sqlite-load-extension", Fsqlite_load_extension,
}
if (!do_allow)
- xsignal1 (Qerror, build_string ("Module name not on allowlist"));
+ xsignal1 (Qsqlite_error, build_string ("Module name not on allowlist"));
int result = sqlite3_load_extension
(XSQLITE (db)->db,
@@ -695,7 +695,7 @@ DEFUN ("sqlite-next", Fsqlite_next, Ssqlite_next, 1, 1, 0,
int ret = sqlite3_step (XSQLITE (set)->stmt);
if (ret != SQLITE_ROW && ret != SQLITE_OK && ret != SQLITE_DONE)
- xsignal1 (Qerror, build_string (sqlite3_errmsg (XSQLITE (set)->db)));
+ xsignal1 (Qsqlite_error, build_string (sqlite3_errmsg (XSQLITE
(set)->db)));
if (ret == SQLITE_DONE)
{
@@ -794,9 +794,15 @@ syms_of_sqlite (void)
defsubr (&Ssqlitep);
defsubr (&Ssqlite_available_p);
+ DEFSYM (Qsqlite_error, "sqlite-error");
+ Fput (Qsqlite_error, Qerror_conditions,
+ Fpurecopy (list2 (Qsqlite_error, Qerror)));
+ Fput (Qsqlite_error, Qerror_message,
+ build_pure_c_string ("Database error"));
+
DEFSYM (Qsqlite_locked_error, "sqlite-locked-error");
Fput (Qsqlite_locked_error, Qerror_conditions,
- Fpurecopy (list2 (Qsqlite_locked_error, Qerror)));
+ Fpurecopy (list3 (Qsqlite_locked_error, Qsqlite_error, Qerror)));
Fput (Qsqlite_locked_error, Qerror_message,
build_pure_c_string ("Database locked"));
--
2.38.0
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Jonas Bernoulli, 2022/10/07
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Lars Ingebrigtsen, 2022/10/08
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Eli Zaretskii, 2022/10/08
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Jonas Bernoulli, 2022/10/08
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Lars Ingebrigtsen, 2022/10/09
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Jonas Bernoulli, 2022/10/10
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Lars Ingebrigtsen, 2022/10/10
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Jonas Bernoulli, 2022/10/14
- bug#58363: [PATCH 0/3] Improve error data signaled by sqlite-execute et al., Jonas Bernoulli, 2022/10/21
- bug#58363: [PATCH 2/3] Introduce a new sqlite-error,
Jonas Bernoulli <=
- bug#58363: [PATCH 2/3] Introduce a new sqlite-error, Michael Albinus, 2022/10/22
- bug#58363: [PATCH 2/3] Introduce a new sqlite-error, Jonas Bernoulli, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Jonas Bernoulli, 2022/10/21
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Eli Zaretskii, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Jonas Bernoulli, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Eli Zaretskii, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Jonas Bernoulli, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Eli Zaretskii, 2022/10/22
- bug#58363: [PATCH 3/3] Improve error data signaled by sqlite-execute et al., Jonas Bernoulli, 2022/10/21
- bug#58363: [PATCH 3/3] Improve error data signaled by sqlite-execute et al., Eli Zaretskii, 2022/10/22