[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type
From: |
Jonas Bernoulli |
Subject: |
bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type |
Date: |
Sat, 22 Oct 2022 12:45:02 +0200 |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Jonas Bernoulli <jonas@bernoul.li>
>> Date: Fri, 21 Oct 2022 23:06:34 +0200
>>
>> * src/sqlite.c (sqlite-load-extension): Use xsignal1.
>> ---
>> src/sqlite.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/sqlite.c b/src/sqlite.c
>> index 1526e344e5..7861a699f4 100644
>> --- a/src/sqlite.c
>> +++ b/src/sqlite.c
>> @@ -675,7 +675,7 @@ DEFUN ("sqlite-load-extension", Fsqlite_load_extension,
>> }
>>
>> if (!do_allow)
>> - xsignal (Qerror, build_string ("Module name not on allowlist"));
>> + xsignal1 (Qerror, build_string ("Module name not on allowlist"));
>
> Why Qerror here and not Qsqlite_error? And if the more general Qerror
> is deliberate, then why not Qmodule_load_failed, for instance?
This commit just fixes a bug.
Qsqlite_error is introduced in the next commit.
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, (continued)
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Lars Ingebrigtsen, 2022/10/09
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Jonas Bernoulli, 2022/10/10
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Lars Ingebrigtsen, 2022/10/10
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Jonas Bernoulli, 2022/10/14
- bug#58363: [PATCH 0/3] Improve error data signaled by sqlite-execute et al., Jonas Bernoulli, 2022/10/21
- bug#58363: [PATCH 2/3] Introduce a new sqlite-error, Jonas Bernoulli, 2022/10/21
- bug#58363: [PATCH 2/3] Introduce a new sqlite-error, Michael Albinus, 2022/10/22
- bug#58363: [PATCH 2/3] Introduce a new sqlite-error, Jonas Bernoulli, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Jonas Bernoulli, 2022/10/21
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Eli Zaretskii, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type,
Jonas Bernoulli <=
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Eli Zaretskii, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Jonas Bernoulli, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Eli Zaretskii, 2022/10/22
- bug#58363: [PATCH 3/3] Improve error data signaled by sqlite-execute et al., Jonas Bernoulli, 2022/10/21
- bug#58363: [PATCH 3/3] Improve error data signaled by sqlite-execute et al., Eli Zaretskii, 2022/10/22
- bug#58363: [PATCH 3/3] Improve error data signaled by sqlite-execute et al., Jonas Bernoulli, 2022/10/22