[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type
From: |
Eli Zaretskii |
Subject: |
bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type |
Date: |
Sat, 22 Oct 2022 14:45:39 +0300 |
> From: Jonas Bernoulli <jonas@bernoul.li>
> Cc: 58363@debbugs.gnu.org
> Date: Sat, 22 Oct 2022 12:45:02 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> - xsignal (Qerror, build_string ("Module name not on allowlist"));
> >> + xsignal1 (Qerror, build_string ("Module name not on allowlist"));
> >
> > Why Qerror here and not Qsqlite_error? And if the more general Qerror
> > is deliberate, then why not Qmodule_load_failed, for instance?
>
> This commit just fixes a bug.
> Qsqlite_error is introduced in the next commit.
This is one reason why I prefer a single patch to series of patches.
(I believe Lars prefers that as well.) It avoids the need to review
patches that are superseded by the following ones, especially when
network delays cause the different parts of the series to be delivered
out of sequence.
So, unless this totally disrupts your workflows, please post patches
as a single coherent changeset, bypassing intermediate steps that are
later superseded. TIA.
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, (continued)
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Jonas Bernoulli, 2022/10/10
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Lars Ingebrigtsen, 2022/10/10
- bug#58363: 29.0.50; sqlite-select does not signal errors and errors should be improved, Jonas Bernoulli, 2022/10/14
- bug#58363: [PATCH 0/3] Improve error data signaled by sqlite-execute et al., Jonas Bernoulli, 2022/10/21
- bug#58363: [PATCH 2/3] Introduce a new sqlite-error, Jonas Bernoulli, 2022/10/21
- bug#58363: [PATCH 2/3] Introduce a new sqlite-error, Michael Albinus, 2022/10/22
- bug#58363: [PATCH 2/3] Introduce a new sqlite-error, Jonas Bernoulli, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Jonas Bernoulli, 2022/10/21
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Eli Zaretskii, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Jonas Bernoulli, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type,
Eli Zaretskii <=
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Jonas Bernoulli, 2022/10/22
- bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type, Eli Zaretskii, 2022/10/22
- bug#58363: [PATCH 3/3] Improve error data signaled by sqlite-execute et al., Jonas Bernoulli, 2022/10/21
- bug#58363: [PATCH 3/3] Improve error data signaled by sqlite-execute et al., Eli Zaretskii, 2022/10/22
- bug#58363: [PATCH 3/3] Improve error data signaled by sqlite-execute et al., Jonas Bernoulli, 2022/10/22