[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58799: Make winner key sequences repeatable in repeat-mode
From: |
Robert Pluim |
Subject: |
bug#58799: Make winner key sequences repeatable in repeat-mode |
Date: |
Thu, 27 Oct 2022 15:38:17 +0200 |
>>>>> On Thu, 27 Oct 2022 05:31:21 -0700, Stefan Kangas
>>>>> <stefankangas@gmail.com> said:
Stefan> Robert Pluim <rpluim@gmail.com> writes:
>> (defvar-keymap winner-repeat-map
>> :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'."
>> <left> #'winner-undo
>> <right> #'winner-redo)
>>
>> (but you can stick them in a .el file)
Stefan> Hmm, right. I think that's a bug though, because when loading such
a
Stefan> .elc file I get:
Stefan> keymap--check: [left] is not a valid key definition; see
‘key-valid-p’
Stefan> So we should probably make sure that the `defvar-keymap' macro
errors
Stefan> out.
Thatʼs easy enough (putting it in `define-keymap' would bring out the
backwards-compatibility police, I think). Probably needs an update to
the `defvar-keymap' docstring as well.
Robert
--
diff --git a/lisp/keymap.el b/lisp/keymap.el
index 107565590c..73a9e657fe 100644
--- a/lisp/keymap.el
+++ b/lisp/keymap.el
@@ -581,6 +581,10 @@ defvar-keymap
(setq key (pop defs))
(pop defs)
(when (not (eq key :menu))
+ (when (not (key-valid-p key))
+ (error
+ "Invalid key '%s' in keymap '%s' (see `key-valid-p')"
+ key variable-name))
(if (member key seen-keys)
(error "Duplicate definition for key '%s' in keymap '%s'"
key variable-name)
- bug#58799: Make winner key sequences repeatable in repeat-mode, Damien Cassou, 2022/10/26
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/26
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode,
Robert Pluim <=
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/28
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/28
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/31
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/31
bug#58799: Make winner key sequences repeatable in repeat-mode, Damien Cassou, 2022/10/30