[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58799: Make winner key sequences repeatable in repeat-mode
From: |
Stefan Kangas |
Subject: |
bug#58799: Make winner key sequences repeatable in repeat-mode |
Date: |
Fri, 28 Oct 2022 08:41:37 -0700 |
Robert Pluim <rpluim@gmail.com> writes:
> (defvar-keymap footnote-minor-mode-map
> :doc "Keymap used for binding footnote minor mode."
> (key-description footnote-prefix) footnote-mode-map)
>
> Thatʼs perfectly valid, but fails with the above patch unless we
>
> 1. Check (key-valid-p (eval key))
> 2. Add an autoload cookie for footnote-minor-mode-map
>
> That seems too high a price to pay for avoiding the original problem.
Hmm, that's a too high price to pay.
Could we check for some common mistakes without having to say `(eval
key)' though? For example by requiring KEY to be
(or (stringp key) (listp key))
?
- bug#58799: Make winner key sequences repeatable in repeat-mode, (continued)
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/26
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/28
- bug#58799: Make winner key sequences repeatable in repeat-mode,
Stefan Kangas <=
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/31
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/31
bug#58799: Make winner key sequences repeatable in repeat-mode, Damien Cassou, 2022/10/30