[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58799: Make winner key sequences repeatable in repeat-mode
From: |
Stefan Kangas |
Subject: |
bug#58799: Make winner key sequences repeatable in repeat-mode |
Date: |
Thu, 27 Oct 2022 09:10:12 -0700 |
Robert Pluim <rpluim@gmail.com> writes:
> Stefan> So we should probably make sure that the `defvar-keymap' macro
> errors
> Stefan> out.
>
> Thatʼs easy enough (putting it in `define-keymap' would bring out the
> backwards-compatibility police, I think). Probably needs an update to
> the `defvar-keymap' docstring as well.
`define-keymap' is new in Emacs 29.1, so I think it will be okay to
change it.
> diff --git a/lisp/keymap.el b/lisp/keymap.el
> index 107565590c..73a9e657fe 100644
> --- a/lisp/keymap.el
> +++ b/lisp/keymap.el
> @@ -581,6 +581,10 @@ defvar-keymap
> (setq key (pop defs))
> (pop defs)
> (when (not (eq key :menu))
> + (when (not (key-valid-p key))
> + (error
> + "Invalid key '%s' in keymap '%s' (see `key-valid-p')"
> + key variable-name))
> (if (member key seen-keys)
> (error "Duplicate definition for key '%s' in keymap '%s'"
> key variable-name)
LGTM.
- bug#58799: Make winner key sequences repeatable in repeat-mode, Damien Cassou, 2022/10/26
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/26
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode,
Stefan Kangas <=
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/27
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/28
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/28
- bug#58799: Make winner key sequences repeatable in repeat-mode, Robert Pluim, 2022/10/31
- bug#58799: Make winner key sequences repeatable in repeat-mode, Stefan Kangas, 2022/10/31
bug#58799: Make winner key sequences repeatable in repeat-mode, Damien Cassou, 2022/10/30