Re: [bug-gnulib] New GNULIB glob module?

[Paul Eggert]

Derek Price <address@hidden> writes:

> # ifndef __USE_GNU
> #  define __USE_GNU     1
> # endif

This shouldn't be needed once the <sys/cdefs.h> change is needed,
because <sys/cdefs.h> should define __USE_GNU.

> +# define GETPW_R_SIZE_MAX()  -1;

Change "-1;" to "(-1)".

> -#endif /* GLOB_ONLY_P */
> +#endif /* !_LIBC || !GLOB_ONLY_P */

More accurately, this should be:

   #endif /* !defined _LIBC || !defined GLOB_ONLY_P */

(The above problem occurs more than once.)

> -               long int pwbuflen = sysconf (_SC_GETPW_R_SIZE_MAX);
> +               long int pwbuflen = GETPW_R_SIZE_MAX();

There should be a space before the opening paren.
(The above problem occurs more than once.)