[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] lib/rename.c: Conditionally define the out label
From: |
Ben Walton |
Subject: |
Re: [PATCH] lib/rename.c: Conditionally define the out label |
Date: |
Mon, 2 Jun 2014 08:52:45 +0100 |
On Sun, Jun 1, 2014 at 11:47 PM, Paul Eggert <address@hidden> wrote:
> Ben Walton wrote:
>>
>> WIth your suggested followup
>> (prerequisite), I think that it's a better solution.
>
>
> Better yet, how about putting the goto-containing code into a subsdiary
> static function that can return rather than goto? That'd be cleaner anyway.
I had considered this, but it didn't feel like the right choice to me.
With a new _GL_UNUSED_LABEL, which is cleaner than my patch, I'm less
inclined. That said, if you folks feel it's the way to go, I will
write the patch to meet your ideals which are more important. :)
Thanks
-Ben
--
---------------------------------------------------------------------------------------------------------------------------
Take the risk of thinking for yourself. Much more happiness,
truth, beauty and wisdom will come to you that way.
-Christopher Hitchens
---------------------------------------------------------------------------------------------------------------------------
- Re: [PATCH] lib/rename.c: Conditionally define the out label, (continued)
- Re: [PATCH] lib/rename.c: Conditionally define the out label, Pádraig Brady, 2014/06/01
- Re: [PATCH] lib/rename.c: Conditionally define the out label, Pádraig Brady, 2014/06/01
- Re: [PATCH] lib/rename.c: Conditionally define the out label, Paul Eggert, 2014/06/01
- Re: [PATCH] lib/rename.c: Conditionally define the out label, Paul Eggert, 2014/06/01
- Re: [PATCH] lib/rename.c: Conditionally define the out label, Pádraig Brady, 2014/06/01
- Re: [PATCH] lib/rename.c: Conditionally define the out label, Paul Eggert, 2014/06/01
- Re: [PATCH] lib/rename.c: Conditionally define the out label, Pádraig Brady, 2014/06/01
- Re: [PATCH] lib/rename.c: Conditionally define the out label, Paul Eggert, 2014/06/01
Re: [PATCH] lib/rename.c: Conditionally define the out label, Ben Walton, 2014/06/01
Re: [PATCH] lib/rename.c: Conditionally define the out label, Ben Walton, 2014/06/02