Re: [semi-PATCH] menu title bar sizing & menu close button

[Fred Kiefer]

Hi Michael,

Michael Hanni wrote:
 > Issues:
 >
 > * NSButton does not honor (NSControl) setRefusesFirstResponder:. I'm
not sure
 > if thats correct or a bug. However, it does cause the dottedRect to
appear in
 > the close button -- ugly.

OK, I looked at the code of NSControl and found what is wrong. The new
setting never gets used! NSControl does not ask the cell, if it accepts
first responder. I will clean this up, now that CVS is finally working 
again.

There are also a lot of problems with setShowsFirstResponder:. I think 
from the documentation that this only indicates that the dotted line 
will be drawn, when the cells also becomes first responder. But our 
current code treats this as unconditional, the value itself determines 
if the dots get drawn. This value is screwed up by the current code in 
NSButton, whenever the button becomes first responder. And even worse in 
NSMatrix. I would like to change this, so that the redraw code of NSCell 
takes over the processing of showsFirstResponder (drawing the dotted 
frame whenever the control is the first responder and the cell is the 
selected cell of the responder) and just selecting the cell everywhere 
else. Is this solution fine for everybody?


BTW: Does anybody know, if showsFirstResponder being YES should be the
default on NSButton?

Fred