[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Recent changed in NSMenu and friends
From: |
Serg Stoyan |
Subject: |
Re: Recent changed in NSMenu and friends |
Date: |
Mon, 31 Mar 2003 01:41:18 +0300 |
Hello Willem,
> Serg Stoyan <stoyan@on.com.ua> writes:
>
> > Hello Willem,
> >
> > > Some changes are done to the NSMenu and friends I am not really
> > > sure about. Especially the changes relating to when
> > > to call update/sizeToFit.
> > >
> > > As it is now it does not work correctly, transient windows
> > > have close buttons etcetera. In my opinion the methods
> >
> > Give me example, please, of such miswork. I have latest CVS and
> > everything works correct for me.
>
> For example the most trivial:
>
> 1 - Open Gorm.app
> 2 - Open Document menu
> 3 - Tear off document menu
> 4 - Click in main menu again on "Document"
> 5 - Notice that the transient version has a close button
> which should not be there.
I see. It's a bug.
> > > 2003-03-30 Willem Rein Oudshoorn <woudshoo@xs4all.nl>
> > >
> > > * Source/NSMenu.m: replaced ivar _changed by _needsSizing
> > > ([NSMenu -sizeToFit]): call [_view sizeToFit] instead of update
> > > ([NSMenu -displayTransient]): added call [_view update]
> > > ([NSMenu -closeTransient]): added [_view update]
> >
> > Why we should update closing transient? What we should update?
>
> When we close we move the NSMenuView from _bWindow to _aWindow.
> At this point in time the "tornOff" state of the "displayed" NSMenu
> changes and therefore we need to update the NSMenuView.
Thanks. I understand now.
--
Serg Stoyan