[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Warnings removed from linux/dev/drivers/block/genhd.c
From: |
Neal H. Walfield |
Subject: |
Re: Warnings removed from linux/dev/drivers/block/genhd.c |
Date: |
Mon, 30 Jan 2006 21:09:38 +0100 |
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/21.4 (i386-pc-linux-gnu) MULE/5.0 (SAKAKI) |
At Mon, 30 Jan 2006 15:37:53 -0200,
Matheus Morais wrote:
>
> Please review, diff file in attached.
Thanks for the contribution. When submitting patches please follow
the following conventions: a description of what you are trying to
accomplish and why. In your case, you should have explained why you
think add_bsd_partition needs to be moved. You allude to it in the
subjuct but what is the warning? How does moving the code fix it?
Second, you need to include a change log. See the ChangeLog files in
the source tree for examples.
Thanks,
Neal
- Warnings removed from linux/dev/drivers/block/genhd.c, Matheus Morais, 2006/01/30
- Re: Warnings removed from linux/dev/drivers/block/genhd.c,
Neal H. Walfield <=
- Re: Warnings removed from linux/dev/drivers/block/genhd.c, Alfred M. Szmidt, 2006/01/30
- Message not available
- Re: Warnings removed from linux/dev/drivers/block/genhd.c, Alfred M. Szmidt, 2006/01/30
- Re: Warnings removed from linux/dev/drivers/block/genhd.c, Neal H. Walfield, 2006/01/30
- Re: Warnings removed from linux/dev/drivers/block/genhd.c, Alfred M. Szmidt, 2006/01/30
- Re: Warnings removed from linux/dev/drivers/block/genhd.c, Neal H. Walfield, 2006/01/30
- Re: Warnings removed from linux/dev/drivers/block/genhd.c, Alfred M. Szmidt, 2006/01/30
- Re: Warnings removed from linux/dev/drivers/block/genhd.c, Marcus Brinkmann, 2006/01/30
- Re: Warnings removed from linux/dev/drivers/block/genhd.c, Matheus Morais, 2006/01/31