[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/17] Move cdrom_sleep() definition where it belongs
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 15/17] Move cdrom_sleep() definition where it belongs |
|
Date: |
Tue, 30 Aug 2011 22:43:54 +0200 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Guillem Jover, le Tue 30 Aug 2011 02:43:03 +0200, a écrit :
> If the original file has to be modified anyway to disable the function
> I don't see the point in arbitrarily moving the function somewhere
> else, more so when it forces the function to be global when it should
> be static.
Right.
> I'm following up with a revised version of the patch, which makes it
> easier to track modifications to the original.
Yes, it is better, I have applied it.
Samuel
- [PATCH 07/17] Add prototype for log function, (continued)
- [PATCH 11/17] Remove unused variables, Guillem Jover, 2011/08/25
- [PATCH 10/17] Remove ident tags producing preprocessor warnings, Guillem Jover, 2011/08/25
- [PATCH 09/17] Add header for printf prototype, Guillem Jover, 2011/08/25
- [PATCH 13/17] Match signedness of char pointer comparisons and assignments, Guillem Jover, 2011/08/25
- [PATCH 16/17] Always initialize A and X variables in BPF code, Guillem Jover, 2011/08/25