Re: [PATCH 5/5] vm: remove unused assignment

[Samuel Thibault]

Marin Ramesa, le Sun 10 Nov 2013 22:50:24 +0100, a écrit :
> Value of src_size is never read. Remove unused assignment.

Same here, I'd rather keep it.

> * vm/vm_map.c: Remove unused assignment.
> 
> ---
>  vm/vm_map.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/vm/vm_map.c b/vm/vm_map.c
> index 2be7147..9d5b01c 100644
> --- a/vm/vm_map.c
> +++ b/vm/vm_map.c
> @@ -3401,7 +3401,7 @@ kern_return_t vm_map_copyin(src_map, src_addr, len, 
> src_destroy, copy_result)
>                       goto VerificationFailed;
>  
>               if (src_entry->vme_end < new_entry->vme_end)
> -                     src_size = (new_entry->vme_end = src_entry->vme_end) - 
> src_start;
> +                     new_entry->vme_end = src_entry->vme_end;
>  
>               if ((src_entry->object.vm_object != src_object) ||
>                   (src_entry->offset != src_offset) ) {
> -- 
> 1.8.1.4
> 
> 

-- 
Samuel
<macavity> bash: ls: Computer bought the farm
<macavity> THAT frightens ppl! :P
<macavity> id rather see: "bash: ls: Initialization of googol(AWAX)
        disengaged in HYPER32/64 mode due to faulty page request at
        AX:12A34F84B"
<macavity> at least that would give me the feeling that the
        *programmers* knows what is going on :P
(lovely Hurd...)