[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] kern (rbtree_insert_rebalance): rewrite node swap
|
From: |
Richard Braun |
|
Subject: |
Re: [PATCH 2/5] kern (rbtree_insert_rebalance): rewrite node swap |
|
Date: |
Tue, 12 Nov 2013 17:37:16 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Nov 12, 2013 at 12:39:40PM +0100, Samuel Thibault wrote:
> Richard Braun, le Tue 12 Nov 2013 11:56:05 +0100, a écrit :
> > It's not a rotation, merely a variable swap,
>
> Ok, but below the comment says
>
> /* Node is the left child of its parent. */
>
> If node is not always updated at this point, the comment does not make
> sense any more.
Agreed.
--
Richard Braun
[PATCH 3/5] kern: eliminate unused assignment, Marin Ramesa, 2013/11/10
[PATCH 4/5] vm: remove duplicate assignment, Marin Ramesa, 2013/11/10
[PATCH 5/5] vm: remove unused assignment, Marin Ramesa, 2013/11/10