Re: [PATCH 40/68] kern/syscall_subr.c: remove forward declaration

[Ivan Shmakov]

>>>>> Marin Ramesa <mpr@hi.t-com.hr> writes:

[…]

 > --- a/kern/syscall_subr.h
 > +++ b/kern/syscall_subr.h
 > @@ -37,5 +37,6 @@ extern int thread_switch(mach_port_t, int, 
 > mach_msg_timeout_t);
 >  extern void thread_depress_timeout(thread_t);
 >  extern kern_return_t thread_depress_abort(thread_t);
 >  extern void mach_print(const char *);
 > +void thread_depress_priority(thread_t thread, mach_msg_timeout_t 
 > depress_time);

        Shouldn’t it be declared as ‘extern’ just as well?  (And the
        argument names are unnecessary, BTW.)  Also, it may make sense
        to “pair” it with thread_depress_timeout (), like:

 > @@ -37,5 +37,6 @@ extern int thread_switch(mach_port_t, int, 
 > mach_msg_timeout_t);
 >  extern void thread_depress_timeout(thread_t);
 > +extern void thread_depress_priority(thread_t, mach_msg_timeout_t);
 >  extern kern_return_t thread_depress_abort(thread_t);

-- 
FSF associate member #7257