Re: Fix a crash in stand-alone Info due to bad indexing of a string

[Eli Zaretskii]

> Date: Fri, 22 Mar 2013 01:44:08 +0300
> From: Sergey Poznyakoff <address@hidden>
> Cc: <address@hidden>, <address@hidden>
> 
> Karl Berry <address@hidden> ha escrit:
> 
> > It's not a feature, it's a bug.
> 
> Actually, I'm not quite sure it is. The capitalization is intended to
> highlight the part of string that is matched. The source states it
> plainly in a comment on line 457:
> 
>     /* If we had a partial match, indicate to the user which part of the
>        string matched. */
> 
> Arguably, there are better ways to highlight the text than upcasing it
> (by using the terminal capabilities, for instance), but that's the way
> the things stood so far, so perhaps we should restore it.
> 
> If, on the other hand, we agree that there's no need in this, I
> can just remove that code which will both remove the cause of the
> coredump and simplify the code greatly.
> 
> Opinions?

I think this _is_ a feature.  Seeing what substring matched is
important to figure out at a single glance whether the hit is relevant
or just a random match, in which case one should type ',' immediately
without even looking at the presented node.

The stand-alone Info reader worked like that since about forever (the
earliest revision in svn, form 2002, already has it).

FWIW, the Emacs Info reader will have a similar feature soon (a patch
was just posted to the developers' list).

So I will be sad if this is removed.