[Cvs-dev] Re: cvs-chpass.patch (former: cvs-passwd.patch)

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Prasad,

Prasad J Pandit <address@hidden> writes:

>     Hello all,
> 
> I hope you remember about cvs-passwd patch. The revised, and improved
> version of it, is available at:
> 
>     http://www.cdacbangalore.in/~prasad/tools

I got your message, but I will not be able to do
anything with the patch right now as real work
deadlines rush up against my holiday plans
(starting next week).

It would be great if another member of the cvs-dev
could do something to aid you in vetting the code
and seeing how it looks in the top-of-tree
sources, but failing that I won't be able to do
much of anything with this stuff until probably
late July. 

I hope and expect that Derek is likely to release
cvs 1.12.14 fairly soon (a few finishing touches
to get windows-NT building again as well as the
SGI systems), so your patch will probably not make
it into that release.
 
> with following major changes...
> 
>     + First of all, the 'passwd' command is now renamed as 'chpass'; As for
>       the interoperability issues(with cvsNT passwd), indicated earlier, by
>       Mark.

Did you raise the issue of using 'chpass' with
address@hidden and "cvsnt-dev"
<address@hidden> in the client/server
protocol yet (if so, I missed it)?

> 
>     + 'chpass', now requires user to do 'cvs
>     login', prior to 'cvs chpass'. Thus,
>     preventing one user from changing other
>     users password.

Good.

>     + A bug relating to CVSROOT/passwd file
>     entry, of the form
> 
>       username::local-username
> 
>       is fixed.
> 
> Ammm... This patch, I've created it for
> cvs-1.12.13 source tree, so Mark, please bear
> with the inconvenience caused by it. And...
> could you please (onec again)give me the latest
> top of tree soruces as you did last time.

A copy of the snapshot of the ccvs FEATURE branch
may be found here:

  http://www.baushke.org/cvs/ccvs.20060620174602Z.tar.bz2
  http://www.baushke.org/cvs/ccvs.20060620174602Z.tar.bz2.sig

do let me know after you fetch the files as my
quota on that system is very near full.

> Thanks!
> -- 
> regards
>      -Prasad
> PS: Please don't send me html/attachment/Fwd mails

A few quick points... regarding
http://www.cdacbangalore.in/~prasad/tools/cvs-chpass-patch.tar.bz2

  1) patches that contain just whitespace changes
     are frowned upon (see your server.c patch
     where you added a tab or your cvs.h file
     where you removed a blank line).

  2) It actually is possible to write better tests
     for passwd that do not need to assume that
     the system has been configured for :pserver:
     by effectively replaying the client side
     responses at a "$testcvs pserver" invocation.
     Examples may be found in the current
     sanity.sh, but they are fairly opaque, so
     maybe someone can help you.

Well, that is all for now.

        Enjoy!
        -- Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (FreeBSD)

iD8DBQFEmEUzCg7APGsDnFERAhUOAKDV0O6r34AxFHmUYYkWf7aQHp/shgCfcHws
+CagqLF1Tzm8LtY4XyMvbys=
=GmPD
-----END PGP SIGNATURE-----