Re: [Discuss-gnuradio] Galois-form LFSR now in trunk (r4613)

[Eric Blossom]

On Fri, Feb 23, 2007 at 12:10:17PM -0800, Johnathan Corgan wrote:
> Trond Danielsen wrote:
> > Is this correct?
> > - - - - - - - - -
> > gr_glfsr_source_b::gr_glfsr_source_b(int degree, bool repeat, int
> > mask, int seed)
> >  : gr_sync_block ("glfsr_source_b",
> >                   gr_make_io_signature (0, 0, 0),
> >                   gr_make_io_signature (1, 1, sizeof(unsigned char))),
> >    d_repeat(repeat),
> >    d_index(0)
> > {
> >  if (degree < 1 || degree > 32)
> >    throw std::runtime_error("gr_glfsr_source_b: degree must be
> > between 1 and 32 inclusive");
> >  d_length = (int)(1ULL << degree)-1;
> >                            ^
> > - - - - -
> 
> Not sure I understand what you're questioning, the formatting is messed
> up.  But now that I stare at it, I think I misplaced a parenthesis; the
> -1 should be inside.


Looks like this needs some QA code.

The original version probably didn't _really_ generate an m-sequence ;)

Eric