[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Discuss-gnuradio] GnuradioConfig.cmake not working properly ?
From: |
Tom Rondeau |
Subject: |
Re: [Discuss-gnuradio] GnuradioConfig.cmake not working properly ? |
Date: |
Thu, 14 Nov 2013 12:47:25 -0500 |
On Thu, Nov 14, 2013 at 12:25 PM, Douglas Geiger
<address@hidden> wrote:
> I think that needs to be applied to the maint branch as well: i.e. Sylvain's
> first patch got applied to both master and maint, but the fix (second patch)
> only ended up on master.
> Doug
Thanks for catching that. Since I had done some other changes to how
GnuradioConfig is used, I thought I only put that on master. Fixed
now.
Tom
> On Wed, Nov 13, 2013 at 11:21 AM, Tom Rondeau <address@hidden> wrote:
>>
>> On Tue, Nov 12, 2013 at 1:28 PM, Martin Braun (CEL)
>> <address@hidden> wrote:
>> > On Tue, Nov 12, 2013 at 06:54:43PM +0100, Sylvain Munaut wrote:
>> >> The attached patch fixes that by re-declaring the variable in the
>> >> parent scope.
>> >>
>> >> This fixes the gr-osmosdr build for me.
>> >> @Martin : could you give it a shot to check it fixes it for you too ?
>> >
>> > Yep, this fixes gr-osmosdr on my side.
>> >
>> > MB
>>
>>
>> Patches applied. I also updated the OOT tutorial to use REQUIRED and
>> gr-modtool now defaults to using the GnuradioConfig style checks with
>> REQUIRED as well.
>>
>> Thanks!
>>
>> Tom
>>
>> _______________________________________________
>> Discuss-gnuradio mailing list
>> address@hidden
>> https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
>
>
>
>
> --
> Doug Geiger
> address@hidden
>
> _______________________________________________
> Discuss-gnuradio mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/discuss-gnuradio
>
- [Discuss-gnuradio] GnuradioConfig.cmake not working properly ?, Sylvain Munaut, 2013/11/10
- Re: [Discuss-gnuradio] GnuradioConfig.cmake not working properly ?, Sylvain Munaut, 2013/11/10
- Re: [Discuss-gnuradio] GnuradioConfig.cmake not working properly ?, Tom Rondeau, 2013/11/11
- Re: [Discuss-gnuradio] GnuradioConfig.cmake not working properly ?, Sylvain Munaut, 2013/11/11
- Re: [Discuss-gnuradio] GnuradioConfig.cmake not working properly ?, Sylvain Munaut, 2013/11/12
- Re: [Discuss-gnuradio] GnuradioConfig.cmake not working properly ?, Martin Braun (CEL), 2013/11/12
- Re: [Discuss-gnuradio] GnuradioConfig.cmake not working properly ?, Tom Rondeau, 2013/11/13
- Re: [Discuss-gnuradio] GnuradioConfig.cmake not working properly ?, Douglas Geiger, 2013/11/14
- Re: [Discuss-gnuradio] GnuradioConfig.cmake not working properly ?,
Tom Rondeau <=