[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GDL2: prototypes and EOAttribute.m
From: |
Fred Kiefer |
Subject: |
Re: GDL2: prototypes and EOAttribute.m |
Date: |
Sun, 14 May 2017 18:15:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
Hi Mark,
thank you very much for this fix on the gdl2 tests. I have applied this
patch. The only thing I did change was instead of commenting out the
TEST_EXCEPTION macros I replaced them with the newer PASS_EXCEPTION calls.
Cheers,
Fred
Am 02.05.2017 um 07:49 schrieb Mark Clements:
> I have now attached a diff file for these changes.
>
> Kindly, Mark.
>
> On 05/01/2017 11:25 PM, Mark Clements wrote:
>> I have had a first attempt at getting the testsuite working with GDL2.
>>
>> It seems to have been a while since the GDL2 testsuite was updated (see
>> patch below). Suggested changes include:
>> + Bug fixes on labelling
>> + Change -cString to -UTF8String
>> + Change sel_eq to sel_isEqual
>> + Change #include "../ObjectTesting.h" to #include "ObjectTesting.h"
>> + Change ADDITIONAL_NATIVE_LIBS+=EOControl EOAccess to
>> ADDITIONAL_NATIVE_LIBS+=EOAccess EOControl (?)
>> + Comment out TEST_EXCEPTION: is this still defined?
>>
>> This gave me 1031 passed tests, 10 failed sets, 9 failed tests and 5
>> failed files.
>>
>> I was not certain whether the failed tests indicate that the Key Value
>> Coding mechanism is broken. Any guidance on this point would be welcomed.
>>
>> Kindly, Mark.
Re: GDL2: prototypes and EOAttribute.m, Matt Rice, 2017/05/02