[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHES] 21.3.50 for Cygwin: patch 5

From: Eli Zaretskii
Subject: Re: [PATCHES] 21.3.50 for Cygwin: patch 5
Date: Sat, 04 Jan 2003 13:07:28 +0300

> Date: Fri, 03 Jan 2003 11:19:15 -0500
> From: Joe Buehler <address@hidden>
> The problem is that _P is defined in the cygwin header files in a manner
> that is incompatible with its usage above.  It is one of a set of macros
> used in code that classifies characters as white space, printable, etc.:

Ouch!  This IMHO warrants a bug report to Cygwin maintainers.

> The above usage in pop.c does not seem correct to me -- aren't symbols
> beginning with _ supposed to be reserved for the compilation system, to avoid
> conflicts such as this one?

That's true, except that _P is used in many libraries' header files to
allow prototypes in ANSI compilers without breaking non-ANSI ones.

Okay, if this is the case, please make the #undef _P thing conditioned
on Cygwin.  That would at least limit the effect of the change to the
Cygwin build.  I'd also suggest a comment there explaining why is this
done, which mentions the use of _P in ctype.h macros.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]