[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 21.3.50 for Cygwin: patch 5
From: |
Kim F. Storm |
Subject: |
Re: 21.3.50 for Cygwin: patch 5 |
Date: |
09 Jan 2003 00:52:33 +0100 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 |
Richard Stallman <address@hidden> writes:
> There are other files in
> lwlib/ (e.g. xlwmenu.c) and src/ (e.g. gmalloc.c, mktime.c,
> and others) which uses __P as well.
>
> For gmalloc.c and mktime.c, this was probably because they were copied
> from Glibc, which can legitimately use names like __P. (There's one
> exception: unexalpha.c.)
>
> In some sense we ought to change these files not to use __P when
> moving the code outside Glibc, but that is unfortunate since it would
> require a fork.
>
> However, it would be better to use P_ instead in the other files.
> That is more consistent with the rest of Emacs, and with the C standard.
The problem is that P_ is defined in src/lisp.h, while __P is defined
in config.h (as defined by configure). I guess that's why __P is used
outside src/ (and some files in src/ as well).
Defining P_ in config.h (via configure) is of course possible, but
even if we change everything (except the Glibc originated files) to
use P_, we still will have the __P definition in config.h -- so IMO
there really isn't a great need to make this change.
--
Kim F. Storm <address@hidden> http://www.cua.dk
- Re: [PATCHES] 21.3.50 for Cygwin: patch 5, Joe Buehler, 2003/01/03
- Re: [PATCHES] 21.3.50 for Cygwin: patch 5, Richard Stallman, 2003/01/04
- Re: [PATCHES] 21.3.50 for Cygwin: patch 5, Kim F. Storm, 2003/01/04
- Re: 21.3.50 for Cygwin: patch 5, Benjamin Riefenstahl, 2003/01/05
- Re: 21.3.50 for Cygwin: patch 5, Kim F. Storm, 2003/01/05
- Re: 21.3.50 for Cygwin: patch 5, Joe Buehler, 2003/01/07
- Re: 21.3.50 for Cygwin: patch 5, Richard Stallman, 2003/01/07
- Re: 21.3.50 for Cygwin: patch 5, Kim F. Storm, 2003/01/07
- Re: 21.3.50 for Cygwin: patch 5, Richard Stallman, 2003/01/07
- Re: 21.3.50 for Cygwin: patch 5,
Kim F. Storm <=
- Re: 21.3.50 for Cygwin: patch 5, Richard Stallman, 2003/01/09
- Re: 21.3.50 for Cygwin: patch 5, Kim F. Storm, 2003/01/10
- Re: 21.3.50 for Cygwin: patch 5, Eli Zaretskii, 2003/01/10
- Re: 21.3.50 for Cygwin: patch 5, Kim F. Storm, 2003/01/10
- Re: 21.3.50 for Cygwin: patch 5, Richard Stallman, 2003/01/12
- Re: 21.3.50 for Cygwin: patch 5, Richard Stallman, 2003/01/10
- Re: [PATCHES] 21.3.50 for Cygwin: patch 5, Richard Stallman, 2003/01/05
Re: [PATCHES] 21.3.50 for Cygwin: patch 5, Eli Zaretskii, 2003/01/04