Re: 21.3.50 for Cygwin: patch 5

[Kim F. Storm]

Benjamin Riefenstahl <address@hidden> writes:

> Pardon me for butting in.
> 
> address@hidden (Kim F. Storm) writes:
> > We already use P_ in most cases (under src/), and __P in a few other
> > cases (mostly under lib-src/ and lwlib/).
> > 
> > So it seems a bit odd that pop.c (as the only file) uses _P.
> > 
> > I suggest we simply change pop.c to use __P like the other files in
> > lib-src.
> 
> Both "__P" and "_P" are both firmly and totally in the compiler domain
> (anything matching the regexp /^_[_A-Z]/ is).  Compilers can use these
> symbols however they see fit.  "P_" OTOH is free for use in user
> programs.  So if a change is needed anyway, it should be to "P_"
> (IMO).

True, but the specific problem is with cygwin and the _P in pop.c;
there doesn't seem to have been reported similar problems with __P, so
we have two options:

1) a small, localized change in pop.c (_P => __P)
2) a wider, non-localized change (_P and __P => P_)

Actually, doing 1 now doesn't mean that we cannot do 2 later...

-- 
Kim F. Storm <address@hidden> http://www.cua.dk