Re: saveplace: don't ask for coding system

[Karl Fogel]

David Reitter <address@hidden> writes:
>> I think you should also add a "-*- coding: XXX -*-" line to the file.
>
> Good idea. I left the coding system at `utf-8', because that's what
> ido seems to use. If there are characters not in utf-8 that file
> systems accept  for file names, it should probably be emacs-mule.

I already committed a version of this change:

  $ head -7 lisp/ChangeLog
  2007-12-02  Karl Fogel  <address@hidden>
  
        * saveplace.el (save-place-alist-to-file): Use `utf-8' coding
        system when writing, and set it in the first-line file variables.
        Based on a patch by David Reitter <dreitter{_AT_}inf.ed.ac.uk>
        and a suggestion by Juanma Barranquero.
  
  $ cvs ci -F lisp/msg lisp/saveplace.el lisp/ChangeLog
  /cvsroot/emacs/emacs/lisp/saveplace.el,v  <--  lisp/saveplace.el
  new revision: 1.40; previous revision: 1.39
  /cvsroot/emacs/emacs/lisp/ChangeLog,v  <--  lisp/ChangeLog
  new revision: 1.12354; previous revision: 1.12353
  Mailing notification to address@hidden sent.
  Mailing diffs to address@hidden 2 sent.
  $ 

I think utf-8 will be fine, practically speaking.

Just now, I've made a followup tweak based on your most recent patch:

  $ head -6 lisp/ChangeLog
  2007-12-02  Karl Fogel  <address@hidden>
  
        * saveplace.el (save-place-alist-to-file): Set
        coding-system-for-write once and refer to it throughout.
        Based on a patch by David Reitter <dreitter{_AT_}inf.ed.ac.uk>.
  
  $ cvs ci -F lisp/msg lisp/saveplace.el lisp/ChangeLog
  /cvsroot/emacs/emacs/lisp/saveplace.el,v  <--  lisp/saveplace.el
  new revision: 1.41; previous revision: 1.40
  /cvsroot/emacs/emacs/lisp/ChangeLog,v  <--  lisp/ChangeLog
  new revision: 1.12355; previous revision: 1.12354
  Mailing notification to address@hidden sent.
  Mailing diffs to address@hidden 2 sent.
  $

> I'll post a separate patch for log level based message filtering
> another time.

I already committed a version of that today too:

   $ head -9 lisp/ChangeLog 
   2007-12-02  Karl Fogel  <address@hidden>
   
        Offer option for saveplace to be quiet about loading and saving.
        Suggested by: David Reitter <dreitter{_AT_}inf.ed.ac.uk>
   
        * lisp/saveplace.el (save-place-quiet): New customizable boolean.
        (save-place-alist-to-file, load-save-place-alist-from-file): Use it
        to determine whether to print loading/saving messages.
   
   $ cvs ci -F m lisp/saveplace.el lisp/ChangeLog
   /cvsroot/emacs/emacs/lisp/saveplace.el,v  <--  lisp/saveplace.el
   new revision: 1.39; previous revision: 1.38
   /cvsroot/emacs/emacs/lisp/ChangeLog,v  <--  lisp/ChangeLog
   new revision: 1.12351; previous revision: 1.12350
   Mailing notification to address@hidden sent.
   Mailing diffs to address@hidden 2 sent.
   $ 

Best,
-Karl