[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Ibuffer: w and B default to buffer at current line

From: Tino Calancha
Subject: Re: Ibuffer: w and B default to buffer at current line
Date: Wed, 14 Sep 2016 16:21:26 +0900 (JST)
User-agent: Alpine 2.20 (DEB 67 2015-01-07)

Thanks for your comments John!

On Tue, 13 Sep 2016, John Wiegley wrote:

"TC" == Tino Calancha <address@hidden> writes:

TC> * lisp/ibuffer.el (ibuffer-get-marked-buffers):
TC> Add an optional parameter BUFFER-AT-LINE: if non-nil and
TC> there are no marked buffers, return the buffer at current line.

Hi Tino,

I don't like this part of your proposed change. The name of the function is
`ibuffer-get-marked-buffers'. Adding a new argument to change the meaning of
the function is not a good idea.
If you compare the first patch with `dired-get-marked-files' (d-g-m-f)
you might change your mind:
(d-g-m-f) returns a list with the file at point when there are no marked files. The first patch follow similar idea.

Instead, there should be a new function `ibuffer-get-buffer-at-point' or some
such, to reflect the meaning you wish to express. There may even already be
such a function, I'm not all that familiar with ibuffer.el.
There is one, ibuffer-current-buffer.
My point is that patch1 allow me to implement 'ibuffer-copy-filename-as-kill' (i-c-f-a-k) very similar as 'dired-copy-filename-as-kill' (d-c-f-a-k). That is nice to me.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]