[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Predicate for true lists
From: |
Basil L. Contovounesios |
Subject: |
Re: Predicate for true lists |
Date: |
Sat, 07 Jul 2018 19:52:26 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
>> From: "Basil L. Contovounesios" <address@hidden>
>> Cc: Paul Eggert <address@hidden>, <address@hidden>
>> Date: Sat, 07 Jul 2018 18:04:28 +0300
>>
>> This function returns the number of elements in @var{sequence}. If
>> address@hidden is a dotted list, a @code{wrong-type-argument} error is
>> -signaled; if it is a circular list, a @code{circular-list} error is
>> -signaled. For a char-table, the value returned is always one more
>> -than the maximum Emacs character code.
>> address@hidden does not satisfy @code{sequencep} or is a dotted list,
>
> It is better to say "If the argument is not a sequence, or is a dotted
> list, ...".
>
>> +a @code{wrong-type-argument} error is signaled; if it is a circular
>
> Please try to avoid passive tense, it usually makes the text longer
> and less clear. I'd suggest
>
> The function signals the @code{wrong-type-argument} error if the
> argument is not a sequence or is a dotted list; it signals the
> @code{circular-list} error if the argument is a circular list.
Thanks, I agree. How's the updated patch:
>From 41fda89f5a161521dcc303e79f308b7c13a61b9d Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <address@hidden>
Date: Sat, 7 Jul 2018 19:33:08 +0300
Subject: [PATCH] Fix (length NON-SEQUENCE) documentation
Suggested by Eli Zaretskii <address@hidden> in the following threads:
https://lists.gnu.org/archive/html/emacs-devel/2018-07/msg00171.html
https://lists.gnu.org/archive/html/emacs-devel/2018-07/msg00206.html
* doc/lispref/sequences.texi (Sequence Functions): Mention that
'length' signals a 'wrong-type-argument' also when given a
non-sequencep argument.
---
doc/lispref/sequences.texi | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/doc/lispref/sequences.texi b/doc/lispref/sequences.texi
index 59faf2b4f1..188a345114 100644
--- a/doc/lispref/sequences.texi
+++ b/doc/lispref/sequences.texi
@@ -71,13 +71,15 @@ Sequence Functions
@cindex list length
@cindex vector length
@cindex sequence length
address@hidden bool-vector length
@cindex char-table length
@anchor{Definition of length}
-This function returns the number of elements in @var{sequence}. If
address@hidden is a dotted list, a @code{wrong-type-argument} error is
-signaled; if it is a circular list, a @code{circular-list} error is
-signaled. For a char-table, the value returned is always one more
-than the maximum Emacs character code.
+This function returns the number of elements in @var{sequence}. The
+function signals the @code{wrong-type-argument} error if the argument
+is not a sequence or is a dotted list; it signals the
address@hidden error if the argument is a circular list. For a
+char-table, the value returned is always one more than the maximum
+Emacs character code.
@xref{Definition of safe-length}, for the related function @code{safe-length}.
--
2.18.0
--
Basil
- RE: Predicate for true lists, (continued)
Re: Predicate for true lists, Paul Eggert, 2018/07/06
- Re: Predicate for true lists, Eli Zaretskii, 2018/07/07
- Re: Predicate for true lists, martin rudalics, 2018/07/07
- Re: Predicate for true lists, Paul Eggert, 2018/07/07
- Re: Predicate for true lists, Eli Zaretskii, 2018/07/07
- Re: Predicate for true lists, Basil L. Contovounesios, 2018/07/07
- Re: Predicate for true lists, Eli Zaretskii, 2018/07/07
- Re: Predicate for true lists,
Basil L. Contovounesios <=
- Re: Predicate for true lists, Eli Zaretskii, 2018/07/07
- Re: Predicate for true lists, Paul Eggert, 2018/07/07
- Re: Predicate for true lists, Eli Zaretskii, 2018/07/07
- RE: Predicate for true lists, Drew Adams, 2018/07/07
- Re: Predicate for true lists, Paul Eggert, 2018/07/08
- RE: Predicate for true lists, Drew Adams, 2018/07/08
- Re: Predicate for true lists, Paul Eggert, 2018/07/08
- RE: Predicate for true lists, Drew Adams, 2018/07/08
- Re: Predicate for true lists, Paul Eggert, 2018/07/08
Re: Predicate for true lists, Basil L. Contovounesios, 2018/07/07