Re: Fill column indicator functionality

[Ergus]

Hi all:

I have been testing all the latest changes with the display-fci-mode and
I have just found that the display-fill-column-indicator variable (and
the others) are not buffer local anymore after the latest changes. So I
cannot enable the mode for some buffers and not for others. 

As in display-line-numbers this works because there are still the
Fmake_variable_buffer_local (Qdisplay_line_numbers); I tested
customize-variable for display-line-numbers variables and it looks like
setting in that way doesn't work as it was happening to
display-fill-column-indicator yesterday.

If I set any of those with set-variable it works. So it is exactly the
same problem I had on yesterday.

So the problem seems to be somewhere else. Any suggestion?

On Sat, Apr 06, 2019 at 10:07:05PM +0300, Eli Zaretskii wrote:
> > Date: Sat, 6 Apr 2019 20:59:36 +0200
> > From: Ergus <address@hidden>
> > Cc: address@hidden
> >
> > I am wondering if there is a way to put conditionals there, because the
> > redisplay needs to be triggered only if one of the variables is already
> > non-nil and we need to redisplay if we change fill-column only if
> > display-fill-column-indicator-column is t. Similar thing should happen
> > for display-line-numbers right?
>
> I don't see why we should bother.  These variables change only rarely,
> so it isn't like they will trigger redisplay frequent enough to be a
> problem.
>
> Btw, if you mean you added display-fill-column-indicator-* variables
> to the list in frame.el, I don't think I see that.  Did I miss
> something?