[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Increase minimum required GTK versions?
From: |
Alex Gramiak |
Subject: |
Re: Increase minimum required GTK versions? |
Date: |
Fri, 12 Apr 2019 13:05:30 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
>> From: Alex <address@hidden>
>> Cc: address@hidden, address@hidden
>> Date: Wed, 10 Apr 2019 18:35:12 -0600
>>
>> >> * Old file selection dialog
>> >> This is only optionally used in GTK 2, but the old dialog is long
>> >> deprecated in GTK 2 (removed in GTK 3), so I figured that this is a good
>> >> time to remove it and simplify the existing code.
>> >
>> > I think this should be left alone. It's a separate issue anyway, and
>> > should be submitted separately. It would be good to try to establish
>> > whether this feature is turned on by someone, but given that it's only
>> > for GTK2, I tend to think we should simply let it die a natural death
>> > together with GTK2.
>>
>> Okay, done.
>
> Are you sure? I still see the code related to this being removed.
That's part of the simplification of the code. Before it uses a
predicate procedure to check the value of x_gtk_use_old_file_dialog,
which I removed in favour of checking the variable directly. It also
used function pointers to wrapper procedures to get the filename, which
I removed in favour of calling the gtk procedures directly. The actual
old file dialog (xg_get_file_with_selection) is, in this patch, still
present. I tested again with GTK 2.24 and GTK 3.10 and it worked as
expected.
Are you okay with this part of the change?
- Re: Increase minimum required GTK versions?, (continued)
- Re: Increase minimum required GTK versions?, Alex, 2019/04/10
- Re: Increase minimum required GTK versions?, Alex Branham, 2019/04/10
- Re: Increase minimum required GTK versions?, Eli Zaretskii, 2019/04/11
- Re: Increase minimum required GTK versions?, Dmitry Gutov, 2019/04/11
- Re: Increase minimum required GTK versions?, Alex, 2019/04/11
- Re: Increase minimum required GTK versions?, Eli Zaretskii, 2019/04/12
- Re: Increase minimum required GTK versions?,
Alex Gramiak <=
- Re: Increase minimum required GTK versions?, Eli Zaretskii, 2019/04/12
- Re: Increase minimum required GTK versions?, Alex Gramiak, 2019/04/12
- Re: Increase minimum required GTK versions?, Eli Zaretskii, 2019/04/12
- Re: Increase minimum required GTK versions?, Alex Gramiak, 2019/04/12
- Re: Increase minimum required GTK versions?, Eli Zaretskii, 2019/04/12
- Re: Increase minimum required GTK versions?, Van L, 2019/04/09