emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Increase minimum required GTK versions?


From: Eli Zaretskii
Subject: Re: Increase minimum required GTK versions?
Date: Fri, 12 Apr 2019 22:14:50 +0300

> From: Alex Gramiak <address@hidden>
> Cc: address@hidden,  address@hidden
> Date: Fri, 12 Apr 2019 13:05:30 -0600
> 
> > Are you sure?  I still see the code related to this being removed.
> 
> That's part of the simplification of the code. Before it uses a
> predicate procedure to check the value of x_gtk_use_old_file_dialog,
> which I removed in favour of checking the variable directly. It also
> used function pointers to wrapper procedures to get the filename, which
> I removed in favour of calling the gtk procedures directly. The actual
> old file dialog (xg_get_file_with_selection) is, in this patch, still
> present. I tested again with GTK 2.24 and GTK 3.10 and it worked as
> expected.

Please don't simplify that part, but instead leave it alone.  And why
was the configure-time test related to that removed?

Please also don't obsolete the variable, I see no reason to do that.
In general, just leave that part out of the patch.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]