emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: set-frame-size should respect line-spacing!?


From: Eli Zaretskii
Subject: Re: set-frame-size should respect line-spacing!?
Date: Sun, 13 Oct 2019 16:20:45 +0300

> Cc: address@hidden, address@hidden
> From: martin rudalics <address@hidden>
> Date: Sun, 13 Oct 2019 14:51:46 +0200
> 
>  >> Sorry for my insistence but 'window-resize' has nothing to do with the
>  >> frame size.
>  >
>  > But this discussion was about set-frame-size, at least that's what I
>  > thought.
> 
> The 'set-frame-size' problem is inherently related to Bug#14825: Both
> are about how to take line spacing and face remapping into account
> when resizing windows.  Just that the former affects the frame size as
> well.

And I was saying that we should be able to solve window-splitting and
resizing use cases while leaving set-frame-size unaffected.

>  >> My concerns are that we call 'window--size-to-pixel' when
>  >> we resize or split a window.  So if we want to special-code the split
>  >> window case and _not_ the 'window-resize' case, I have to either
>  >> special-code 'window--size-to-pixel' too or call some other function
>  >> instead.
>  >
>  > What is the window-resize case?
> 
> That of how it should handle line spacing and face remapping when
> resizing a window.  For example, how should we relate the desired
> height of a window to the value of 'window-min-height' when these are
> in effect?

I think the only case where the issues raised by bug#14825 should
matter is when we decide whether a window is too small.  E.g., what
bad things will happen if we interpret window-min-height in terms of
the default face's font set for the buffer shown (or to be shown) in
the window?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]