[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Review request (compilation-error-regexp-alist-alist)
From: |
Filipp Gunbin |
Subject: |
Review request (compilation-error-regexp-alist-alist) |
Date: |
Mon, 28 Oct 2019 23:50:59 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) |
Hi, could you please review this to check I haven't done anything
obviously wrong?
Thanks.
Filipp
diff --git a/etc/compilation.txt b/etc/compilation.txt
index 0e39ab5e4a..4a4a318d03 100644
--- a/etc/compilation.txt
+++ b/etc/compilation.txt
@@ -185,6 +185,14 @@ Warning near line 10 file arrayclash.f: Module contains no
executable
Nonportable usage near line 31 col 9 file assign.f: mixed default and explicit
+* Gradle with kotlin-gradle-plugin
+
+symbol: gradle-kotlin
+
+e: /src/Test.kt: (34, 15): foo: bar
+w: /src/Test.kt: (34, 15): foo: bar
+
+
* IAR Systems C Compiler
symbol: iar
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index cd7a5dc677..24c8a2a312 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -236,6 +236,15 @@ compilation-error-regexp-alist-alist
"\\(^Warning .*\\)? line[ \n]\\([0-9]+\\)[ \n]\\(?:col \\([0-9]+\\)[
\n]\\)?file \\([^ :;\n]+\\)"
4 2 3 (1))
+ ;; Gradle with kotlin-gradle-plugin (see
+ ;; GradleStyleMessagerRenderer.kt in kotlin sources).
+ (gradle-kotlin
+ ,(concat
+ "^\\(?:\\(w\\)\\|.\\): *" ;type
+ "\\(\\(?:[A-Za-z]:\\)?[^:\n]+\\): *" ;file
+ "(\\([0-9]+\\), *\\([0-9]+\\))") ;line, column
+ 2 3 4 (1))
+
(iar
"^\"\\(.*\\)\",\\([0-9]+\\)\\s-+\\(?:Error\\|Warnin\\(g\\)\\)\\[[0-9]+\\]:"
1 2 nil (3))
diff --git a/test/lisp/progmodes/compile-tests.el
b/test/lisp/progmodes/compile-tests.el
index 08a369e7b5..e38c31dd0a 100644
--- a/test/lisp/progmodes/compile-tests.el
+++ b/test/lisp/progmodes/compile-tests.el
@@ -212,6 +212,13 @@ compile-tests--test-regexps-data
1 nil 27041 "{standard input}")
("boost/container/detail/flat_tree.hpp:589:25: [ skipping 5
instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]"
1 25 589 "boost/container/detail/flat_tree.hpp" 0)
+ ;; gradle-kotlin
+ ("e: /src/Test.kt: (34, 15): foo: bar" 4 15 34 "/src/Test.kt" 2)
+ ("w: /src/Test.kt: (11, 98): foo: bar" 4 98 11 "/src/Test.kt" 1)
+ ("e: e:/cygwin/src/Test.kt: (34, 15): foo: bar" 4 15 34
"e:/cygwin/src/Test.kt" 2)
+ ("w: e:/cygwin/src/Test.kt: (11, 98): foo: bar" 4 98 11
"e:/cygwin/src/Test.kt" 1)
+ ("e: e:\\src\\Test.kt: (34, 15): foo: bar" 4 15 34 "e:\\src\\Test.kt" 2)
+ ("w: e:\\src\\Test.kt: (11, 98): foo: bar" 4 98 11 "e:\\src\\Test.kt" 1)
;; Guile
("In foo.scm:\n" 1 nil nil "foo.scm")
(" 63:4 [call-with-prompt prompt0 ...]" 1 4 63 nil)
@@ -413,8 +420,8 @@ compile--test-error-line
(compilation-num-warnings-found 0)
(compilation-num-infos-found 0))
(mapc #'compile--test-error-line compile-tests--test-regexps-data)
- (should (eq compilation-num-errors-found 87))
- (should (eq compilation-num-warnings-found 32))
+ (should (eq compilation-num-errors-found 90))
+ (should (eq compilation-num-warnings-found 35))
(should (eq compilation-num-infos-found 26)))))
(ert-deftest compile-test-grep-regexps ()
- Review request (compilation-error-regexp-alist-alist),
Filipp Gunbin <=
- Re: Review request (compilation-error-regexp-alist-alist), Stefan Monnier, 2019/10/28
- Re: Review request (compilation-error-regexp-alist-alist), Filipp Gunbin, 2019/10/28
- Re: Review request (compilation-error-regexp-alist-alist), Stefan Monnier, 2019/10/28
- Re: Review request (compilation-error-regexp-alist-alist), Filipp Gunbin, 2019/10/28
- Re: Review request (compilation-error-regexp-alist-alist), Stefan Monnier, 2019/10/29
- Re: Review request (compilation-error-regexp-alist-alist), Filipp Gunbin, 2019/10/29
- Re: Review request (compilation-error-regexp-alist-alist), Stefan Monnier, 2019/10/29
- Re: Review request (compilation-error-regexp-alist-alist), Filipp Gunbin, 2019/10/29
- Re: Review request (compilation-error-regexp-alist-alist), Stefan Monnier, 2019/10/29
- Re: Review request (compilation-error-regexp-alist-alist), Filipp Gunbin, 2019/10/29