emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master f225011: ibuffer-do-isearch: don't depend on `cl-values-list'


From: Juanma Barranquero
Subject: Re: master f225011: ibuffer-do-isearch: don't depend on `cl-values-list' (bug#38430)
Date: Mon, 2 Dec 2019 00:36:32 +0100

On Sun, Dec 1, 2019 at 7:29 PM Stefan Monnier <address@hidden> wrote:

> This is "broken" in the sense that it makes assumptions about how the
> "multiple values" are implemented.

Yes, though we've had that implementation for decades and we're not likely going to add true multiple values to elisp.

> We do know that `ibuffer-split-list` returns a list, so there's no point
> going through CL's multiple-values simulation.  We should instead treat
> it as a list and extract the elements with `pcase-let`
> (or `cl-destructuring-bind`).

I tried to do a minimal fix so close to branching for 27, but I can do that if you want.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]