[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 64e25cd: More robust NS hex colour string parsing

From: Eli Zaretskii
Subject: Re: master 64e25cd: More robust NS hex colour string parsing
Date: Fri, 12 Jun 2020 22:11:10 +0300

> From: Mattias Engdegård <mattiase@acm.org>
> Date: Fri, 12 Jun 2020 21:00:10 +0200
> Cc: pipcet@gmail.com, emacs-devel@gnu.org
> 12 juni 2020 kl. 19.33 skrev Eli Zaretskii <eliz@gnu.org>:
> > Were the 4 versions identical or different?  If the latter, what were
> > the differences, and which of the features that call them will from
> > now on behave differently?
> They were not semantically equivalent but clearly intended to be. Only the X 
> and Windows versions accepted the rgbi: format; most if not all had bad 
> error-checking (simple typos silently giving nonsense values), and the 
> Windows version appears to have normalised incorrectly in some cases (this is 
> from reading the code with no Windows machine handy).
> The new code should parse a superset of what the old code did, detect more 
> mistakes, and be as accurate as we can make it.

Thanks, but I don't think I understand the answer well enough to make
up my mind regarding the proposed code.  The error checking aside, are
the return values of the original code the same as of the proposed
unified code?  If not, which of the 4 current versions differ, and

reply via email to

[Prev in Thread] Current Thread [Next in Thread]