Re: Integration of dictionary package

[Eli Zaretskii]

> From: Torsten Hilbrich <emacs.nolkaf@hilbrich.tk>
> Date: Thu, 19 Nov 2020 08:40:21 +0100
> Cc: orontee@gmail.com
> 
> I have now completed the work on my branch
> feature/integration-of-dictionary-el. For reference, here is a list of
> the commits so far:

Thanks, a few minor comments:

  . Please add a NEWS entry about the package, with a couple of
    sentences describing its main features, and maybe mentioning one
    or two main commands to use it.

  . Our conventions are to make the first line of every doc string a
    complete sentence which ends with a period.  It should also
    mention the arguments of the function, if any.  I see that many
    first lines in your doc strings lack the period, and some first
    sentences take more than one line and/or don't mention the
    arguments.

Please add a NEWS entry before you merge, but the other issues can be
worked on after the merge.