Re: master 11abc4a: Merge remote-tracking branch 'origin/scratch/lexical-gnus' into trunk

[Katsumi Yamaoka]

On Sun, 31 Jan 2021 17:39:54 -0500, Stefan Monnier wrote:
> branch: master
> commit 11abc4aef42ceaea451c264e5a7292e765d4f31b
> Merge: cb72b83 d2341eb
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>

>     Merge remote-tracking branch 'origin/scratch/lexical-gnus' into trunk

It's not a bug but my custom face setting got to malfunction by
this change, i.e., to turn lexical-binding on on the gnus files.
My custom face setting is something like the following:

(push '((string-match "REGEX" group) . custom-face)
      gnus-group-highlight)

Where `group' is a group name; it aimed to highlight groups of
which the name match "REGEX" by `custom-face' in the Group buffer.
However, `group' is no longer a bound variable now.  So, I'd like
to add `group' to an env list in `gnus-group-update-eval-form' as
the patch below.  Is it ok?  Thanks.

--- gnus-group.el~      2021-02-01 22:35:19.611070900 +0000
+++ gnus-group.el       2021-02-02 00:41:32.041329700 +0000
@@ -1639,5 +1639,6 @@
             (cons 'score (or (gnus-info-score info) 0))
             (cons 'ticked (gnus-range-length (cdr (assq 'tick marked))))
-            (cons 'group-age (gnus-group-timestamp-delta group)))))
+            (cons 'group-age (gnus-group-timestamp-delta group))
+            (cons 'group group))))
       (while (and list
                   (not (eval (caar list) env)))