[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ELPA] A Setup package
From: |
Philip Kaludercic |
Subject: |
Re: [ELPA] A Setup package |
Date: |
Sat, 13 Mar 2021 20:44:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I think all the issues should now be resolved. I just pushed a commit
>> adding edebug support. setup-help was moved into setup's docstring, a
>> lot of the macros were redefined to look more like setq, and all macros
>> were redefined to use keywords (for now).
>
> [ I have some further suggestions for the code, but they'll come later. ]
>
> I was about to add it to GNU ELPA, but I noticed two problems:
>
> 1- The file is missing a copyright notice and it is using the CC0 license.
> See the patch below to fix those issues (the copyright part reflects
> the fact that you consider the package as being covered by your
> copyright assignment and the license change is because we want to
> distribute all GNU ELPA packages under the GPLv3 license; you're of
> course perfectly free to also distribute this package under any other
> license you want, but we want to use the GPLv3 for the copy we
> distribute).
Done.
> 2- AFAIK you rebased (or force-pushed or something like that) your
> branch, which makes it painful for any"one" tracking your branch, such
> as elpa.git. In order for the elpa.git branch tracking your
> SourceHut repository to work sanely it'll be important not to rebase
> (or force-push...) in the future.
I actually created a new repository, because it seemed cleaner compared
to pushing all the changes as commits. But I will keep this in mind for
the future.
--
Philip K.
- Re: [ELPA] A Setup package, Philip Kaludercic, 2021/03/11
- Re: [ELPA] A Setup package, Stefan Monnier, 2021/03/13
- Re: [ELPA] A Setup package,
Philip Kaludercic <=
- Re: [ELPA] A Setup package, Stefan Monnier, 2021/03/14
- Re: [ELPA] A Setup package, Philip Kaludercic, 2021/03/14
- Re: [ELPA] A Setup package, Stefan Monnier, 2021/03/14
- Re: [ELPA] A Setup package, Philip Kaludercic, 2021/03/14
- Re: [ELPA] A Setup package, Stefan Monnier, 2021/03/15
- Re: [ELPA] A Setup package, Philip Kaludercic, 2021/03/15