emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp def


From: Basil L. Contovounesios
Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063)
Date: Fri, 26 Mar 2021 15:36:24 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Yup; if it's hoisted out of the loop, there'd be no performance impact,
>> but it would make it less useful, though -- as with erroring out, you'd
>> get no completion.
>
> It'd make more sense to just keep the current (not-filtered) completion
> list, so you still get completion to work.

If we stick with the original patch, then that would mean returning
non-nil rather than nil if completion-predicate fails, right?

-- 
Basil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]