Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063)

[Stefan Monnier]

>>> Yup; if it's hoisted out of the loop, there'd be no performance impact,
>>> but it would make it less useful, though -- as with erroring out, you'd
>>> get no completion.
>>
>> It'd make more sense to just keep the current (not-filtered) completion
>> list, so you still get completion to work.
>
> If we stick with the original patch, then that would mean returning
> non-nil rather than nil if completion-predicate fails, right?

I don't think whether we include the command for which the predicate
burped is important: either way is fine.  OTOH, it would be preferable
if a burping predicate wouldn't prevent the inclusion of other commands
in the completion list.  It's probably tolerable to just prevent
completion altogether in case of an error, but not to prevent
`M-x` altogether.


        Stefan