Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063)

[Basil L. Contovounesios]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>>> What's the performance impact here?  This is going to be called a whole
>>>> bunch of times when the user hits TAB...
>>> It should be OK to do the condition-case wrapping around the loop rather
>>> than within it, so the performance impact should be negligible.
>> "Around the loop" means "around completing-read",
>
> Not necessarily, e.g.

> @@ -1998,11 +1999,12 @@ read-extended-command
>                  "M-X "
>                "M-x "))
>         (lambda (string pred action)
> -         (if (and suggest-key-bindings (eq action 'metadata))
> -          '(metadata
> -            (affixation-function . read-extended-command--affixation)
> -            (category . command))
> -           (complete-with-action action obarray string pred)))
> +         (with-demoted-errors "Completion error: %S"
> +           (if (and suggest-key-bindings (eq action 'metadata))
> +            '(metadata
> +              (affixation-function . read-extended-command--affixation)
> +              (category . command))
> +             (complete-with-action action obarray string pred))))

Oops, indeed.

But as we've agreed elsewhere, leaving the completion table empty is not
ideal.

-- 
Basil