emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch proposal: display symbol source code in help buffers


From: Lars Ingebrigtsen
Subject: Re: Patch proposal: display symbol source code in help buffers
Date: Tue, 21 Sep 2021 18:49:49 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Ihor Radchenko <yantar92@gmail.com> writes:

> Agree. I updated the patch and also added support for
> widen-automatically variable. See below.

[...]

> diff --git a/lisp/help-mode.el b/lisp/help-mode.el
> index 551cf7e1a3..57655db337 100644
> --- a/lisp/help-mode.el
> +++ b/lisp/help-mode.el
> @@ -268,6 +268,7 @@ help-function-def--button-function
>              (when (or (< position (point-min))
>                        (> position (point-max)))
>                (widen))
> +            (push-mark nil t)

I was thinking something slightly more subtle.  That is, if we've just
opened the file (i.e., it has not been displayed before), we should not
push the mark.  And if point didn't move, we shouldn't push the mark
either, I think.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



reply via email to

[Prev in Thread] Current Thread [Next in Thread]