emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 6ed1994d27: Prevent crashes from illegal locale coding system


From: Po Lu
Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding systems
Date: Wed, 16 Feb 2022 21:40:57 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux)

Eli Zaretskii <eliz@gnu.org> writes:

> I guess I don't understand what you want to install.  Can you show a
> patch?

Sure, thanks:

diff --git a/src/xterm.c b/src/xterm.c
index b55a54b945..9fa725e9f3 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -8734,6 +8734,15 @@ handle_one_xevent (struct x_display_info *dpyinfo,
              {
                /* Decode the input data.  */
 
+#ifdef HAVE_GLIB
+               /* If this isn't done in a build with GLib (usually
+                  with GTK), then the resulting signal in
+                  `setup_coding_system' will cause Emacs to
+                  crash.  */
+               if (NILP (Fcoding_system_p (coding_system)))
+                 goto done_keysym;
+#endif
+
                /* The input should be decoded with `coding_system'
                   which depends on which X*LookupString function
                   we used just above and the locale.  */


reply via email to

[Prev in Thread] Current Thread [Next in Thread]