[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [elpa] externals/osm 05ac461360: Bail out earlier if dependencies ar
From: |
Philip Kaludercic |
Subject: |
Re: [elpa] externals/osm 05ac461360: Bail out earlier if dependencies are missing |
Date: |
Wed, 11 May 2022 06:34:48 +0000 |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Daniel Mendler [2022-05-11 00:07:31] wrote:
>> On 5/10/22 23:00, Stefan Monnier wrote:
>
>> The alternative would be to replicate the check in all the
>> entry points to the package, the osm-mode, the autoloaded osm-*
>> commands, which would require more code.
>
> The "right" place for such checks is as soon as you know that you *will*
> definitely encounter an error.
>
> When the file is being loaded, you don't know yet that an error is
> inevitable because you don't know yet whether the loaded code will
> be called.
My understanding in this case is that the basic functionality of osm.el
requires efficient JSON parsing to be available. Without this, the
package becomes "prohibitively slow" (at least according to bug#55278).
Perhaps it would be better to add a helper function that does the check
and issues an error/warning, and call this at all entry-points?