[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 5743b74d4b 1/2: Improve mouse dragging
From: |
Po Lu |
Subject: |
Re: master 5743b74d4b 1/2: Improve mouse dragging |
Date: |
Fri, 13 May 2022 20:45:23 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> If we come up with a safe enough fix, we could consider backporting it
> to the release branch.
I think the display issue is not serious enough to backport (and
probably can't be fixed safely).
But the tooltip face overwriting the text completely prevents any
meaningful use of `mouse-drag-and-drop-region'. This is enough to fix
that bug alone:
diff --git a/lisp/mouse.el b/lisp/mouse.el
index 1b9542b9b8..e5ea5475f4 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -3049,7 +3049,7 @@ mouse-drag-and-drop-region
;; Show a tooltip.
(if mouse-drag-and-drop-region-show-tooltip
- (tooltip-show text-tooltip)
+ (tooltip-show (copy-sequence text-tooltip))
(tooltip-hide))
;; Show cursor and highlight the original region.
WDYT?
- Re: master 5743b74d4b 1/2: Improve mouse dragging, (continued)
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Po Lu, 2022/05/12
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Eli Zaretskii, 2022/05/12
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Po Lu, 2022/05/12
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Eli Zaretskii, 2022/05/13
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Po Lu, 2022/05/13
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Eli Zaretskii, 2022/05/13
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Po Lu, 2022/05/13
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Eli Zaretskii, 2022/05/13
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Po Lu, 2022/05/13
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Eli Zaretskii, 2022/05/13
- Re: master 5743b74d4b 1/2: Improve mouse dragging,
Po Lu <=
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Eli Zaretskii, 2022/05/13
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Eli Zaretskii, 2022/05/13
- Re: master 5743b74d4b 1/2: Improve mouse dragging, Po Lu, 2022/05/13
- RE: [External] : Re: master 5743b74d4b 1/2: Improve mouse dragging, Drew Adams, 2022/05/12
- Re: [External] : Re: master 5743b74d4b 1/2: Improve mouse dragging, Po Lu, 2022/05/12
- RE: [External] : Re: master 5743b74d4b 1/2: Improve mouse dragging, Drew Adams, 2022/05/12
- Re: [External] : Re: master 5743b74d4b 1/2: Improve mouse dragging, Po Lu, 2022/05/12
- RE: [External] : Re: master 5743b74d4b 1/2: Improve mouse dragging, Drew Adams, 2022/05/13
- Re: [External] : Re: master 5743b74d4b 1/2: Improve mouse dragging, Po Lu, 2022/05/13