emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 5743b74d4b 1/2: Improve mouse dragging


From: Eli Zaretskii
Subject: Re: master 5743b74d4b 1/2: Improve mouse dragging
Date: Fri, 13 May 2022 15:48:20 +0300

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 13 May 2022 20:45:23 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > If we come up with a safe enough fix, we could consider backporting it
> > to the release branch.
> 
> I think the display issue is not serious enough to backport (and
> probably can't be fixed safely).
> 
> But the tooltip face overwriting the text completely prevents any
> meaningful use of `mouse-drag-and-drop-region'.  This is enough to fix
> that bug alone:
> 
> diff --git a/lisp/mouse.el b/lisp/mouse.el
> index 1b9542b9b8..e5ea5475f4 100644
> --- a/lisp/mouse.el
> +++ b/lisp/mouse.el
> @@ -3049,7 +3049,7 @@ mouse-drag-and-drop-region
>  
>            ;; Show a tooltip.
>            (if mouse-drag-and-drop-region-show-tooltip
> -              (tooltip-show text-tooltip)
> +              (tooltip-show (copy-sequence text-tooltip))
>              (tooltip-hide))
>  
>            ;; Show cursor and highlight the original region.
> 
> WDYT?

This is okay for the release branch, thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]