[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 97400c4c24: Make printing mostly non-recursive (bug#55481)
From: |
Po Lu |
Subject: |
Re: master 97400c4c24: Make printing mostly non-recursive (bug#55481) |
Date: |
Wed, 18 May 2022 17:55:33 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) |
Mattias EngdegÄrd <mattiase@acm.org> writes:
> +struct print_pp_entry {
> + ptrdiff_t n; /* number of values, or 0 if a single
> value */
> + union {
> + Lisp_Object value; /* when n = 0 */
> + Lisp_Object *values; /* when n > 0 */
> + } u;
> +};
> +
> +struct print_pp_stack {
> + struct print_pp_entry *stack; /* base of stack */
> + ptrdiff_t size; /* allocated size in entries */
> + ptrdiff_t sp; /* current number of entries */
> +};
Thanks; however, I think our coding style is to put the opening brace of
structs, enums and unions on column 1, so this should be:
> +struct print_pp_entry
> +{
> + ptrdiff_t n; /* number of values, or 0 if a single
> value */
> + union
> + {
> + Lisp_Object value; /* when n = 0 */
> + Lisp_Object *values; /* when n > 0 */
> + } u;
> +};
> +
> +struct print_pp_stack
> +{
> + struct print_pp_entry *stack; /* base of stack */
> + ptrdiff_t size; /* allocated size in entries */
> + ptrdiff_t sp; /* current number of entries */
> +};
Instead.
- Re: master 97400c4c24: Make printing mostly non-recursive (bug#55481),
Po Lu <=