[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Integrate my package into Emacs
From: |
Stefan Monnier |
Subject: |
Re: Integrate my package into Emacs |
Date: |
Tue, 24 May 2022 19:11:54 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
> See patch below which includes the copyright change along with various
> FIXME comments (meant to be read rather than applied. If you have any
> questions/answers about those FIXMEs, feel free to send them right here).
One more comment: it would be good to expand the docstring of
`cl-defgeneric inspect-object` to clarify what is expected from methods
of this generic function. E.g. specify that they're supposed to write
into the current-buffer, clarify if that buffer can be presumed to be
empty or not and what kind of formatting it can/should obey
(e.g. mention that they're expected to use
`inspector--insert-inspect-button` when inserting a sub-object).
Also, I'm curious why you used a default method for that generic
function where you have a big `cond` dispatching on the type of the
argument: why not use separate methods instead?
Stefan
- Re: Integrate my package into Emacs, Mariano Montone, 2022/05/24
- Re: Integrate my package into Emacs, Stefan Monnier, 2022/05/24
- Re: Integrate my package into Emacs,
Stefan Monnier <=
- Re: Integrate my package into Emacs, Mariano Montone, 2022/05/26
- Re: Integrate my package into Emacs, Stefan Monnier, 2022/05/26
- Re: Integrate my package into Emacs, Mariano Montone, 2022/05/26
- Re: Integrate my package into Emacs, Stefan Monnier, 2022/05/26
- Re: Integrate my package into Emacs, Mariano Montone, 2022/05/26
- Re: Integrate my package into Emacs, Mariano Montone, 2022/05/26
- Re: Integrate my package into Emacs, Stefan Monnier, 2022/05/26