[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tree-sitter integration on feature/tree-sitter
From: |
Yuan Fu |
Subject: |
Re: Tree-sitter integration on feature/tree-sitter |
Date: |
Mon, 20 Jun 2022 21:39:34 -0700 |
> On Jun 20, 2022, at 7:26 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Mon, 20 Jun 2022 13:01:32 -0700
>> Cc: emacs-devel@gnu.org
>>
>> Major mode should set beginning-of-defun-function to
>> treesit-beginning-of-defun, not unlike what they already do with major
>> mode-specific beginning-of-defun functions. This way major mode has the
>> freedom to decide which treesit features it wants to leverage.
>
> Then those tree-sitter functions should be described together with
> beginning/end-of-defun, I think.
Cool.
>
>>>> Treesit-beginning/end-of-defun jumps to the beginning/end of the current
>>>> defun form, treesit-search-beginning searches for a query and stops at the
>>>> beginning/end of the node that matched the query.
>>>
>>> So you are saying treesit-beginning/end-of-defun don't actually look
>>> for beginning and end of a function, but for beginning and end of a
>>> more abstract entity? Then perhaps it would be wrong to have "defun"
>>> in their names? And in that case, maybe a separate section (under
>>> "Motion") is better after all, since this is no longer "List Motion",
>>> strictly speaking.
>>
>> The second sentence describes treesit-search-beginning, not
>> treesit-beginning-of-defun, I think you confused the two?
>
> Maybe so, but why did you mention treesit-search-beginning in this
> context to begin with?
They are another set of functions that I wonder where to put manual entries in.
I’ll probably put them in 35.1 Searching for Strings, after search-forward.
Yuan
- Re: Tree-sitter integration on feature/tree-sitter, (continued)
- Re: Tree-sitter integration on feature/tree-sitter, Yuan Fu, 2022/06/17
- Re: Tree-sitter integration on feature/tree-sitter, Eli Zaretskii, 2022/06/18
- Re: Tree-sitter integration on feature/tree-sitter, Yuan Fu, 2022/06/18
- Re: Tree-sitter integration on feature/tree-sitter, Eli Zaretskii, 2022/06/18
- Re: Tree-sitter integration on feature/tree-sitter, Yuan Fu, 2022/06/18
- Re: Tree-sitter integration on feature/tree-sitter, Eli Zaretskii, 2022/06/19
- Re: Tree-sitter integration on feature/tree-sitter, Yuan Fu, 2022/06/19
- Re: Tree-sitter integration on feature/tree-sitter, Eli Zaretskii, 2022/06/20
- Re: Tree-sitter integration on feature/tree-sitter, Yuan Fu, 2022/06/20
- Re: Tree-sitter integration on feature/tree-sitter, Eli Zaretskii, 2022/06/20
- Re: Tree-sitter integration on feature/tree-sitter,
Yuan Fu <=
- Re: Tree-sitter integration on feature/tree-sitter, Eli Zaretskii, 2022/06/21
- Re: Tree-sitter integration on feature/tree-sitter, Yuan Fu, 2022/06/21
Re: Tree-sitter integration on feature/tree-sitter, Jostein Kjønigsen, 2022/06/17
Re: Tree-sitter integration on feature/tree-sitter, Yuan Fu, 2022/06/16