emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Call for volunteers: add tree-sitter support to major modes


From: Yuan Fu
Subject: Re: Call for volunteers: add tree-sitter support to major modes
Date: Tue, 11 Oct 2022 01:51:29 -0700


> On Oct 11, 2022, at 12:13 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Mon, 10 Oct 2022 22:14:36 -0700
>> Cc: Theodor Thornhill <theo@thornhill.no>,
>> Eli Zaretskii <eliz@gnu.org>,
>> Alan Mackenzie <acm@muc.de>,
>> emacs-devel <emacs-devel@gnu.org>,
>> jostein@kjonigsen.net
>> 
>> Tree-sitter library and the “official” language definitions are all MIT 
>> licensed. So nothing prevents us from including it copyright-wise.
> 
> I see no reason whatsoever to consider bundling tree-sitter.  Building
> it is very easy, and w=once Emacs starts using it seriously, the Emacs
> distros will take care of offering suitable tree-sitter distributions.

I agree, I was replying to Po’s explaining there is no copyright issue.

> 
>>> My opinion is that Emacs should not degrade its text editing
>>> capabilities so drastically if a non-system library (i.e. not ncurses or
>>> Xlib) is not present.
>> 
>> Considering that Emacs currently doesn’t have C# and typescript support in 
>> core at all, I wouldn’t call it a downgrade. But I agree the idea that a 
>> major mode requiring external dependency to function is not very comfortable.
> 
> I don't agree, and don't feel myself uncomfortable at all.  For the
> same reason I don't feel uncomfortable because we use HarfBuzz for
> rendering and GnuTLS for networking.

Oh, I’m perfectly comfortable with having build dependency on tree-sitter. I 
was not comfortable with having a built-in major mode that simply errors out 
when tree-sitter is not available. But if we are going to include some minimal 
support into typescript-mode in the case where tree-sitter is unavailable, as 
you suggested in a message, then I’m very comfortable ;-)

Yuan


reply via email to

[Prev in Thread] Current Thread [Next in Thread]