emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Initial fontification in sh-mode with tree-sittter


From: Eli Zaretskii
Subject: Re: Initial fontification in sh-mode with tree-sittter
Date: Sun, 13 Nov 2022 09:26:27 +0200

> From: Yuan Fu <casouri@gmail.com>
> Date: Sat, 12 Nov 2022 23:01:30 -0800
> Cc: João Paulo Labegalini de Carvalho <jaopaulolc@gmail.com>,
>  emacs-devel@gnu.org
> 
> 
> 
> > On Nov 12, 2022, at 10:23 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > 
> >> From: João Paulo Labegalini de Carvalho <jaopaulolc@gmail.com>
> >> Date: Sat, 12 Nov 2022 15:04:26 -0700
> >> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> >> 
> >> I see. This is tree-sitter-bash’s problem. When there are only newlines 
> >> between two EOF’s, the parser
> >> erroneously marks everything that follows as heredoc_body. I tried 
> >> tree-sitter’s online demo and it gives
> >> the same result[1]. We should report this to tree-sitter-bash’s author.
> >> 
> >> Sorry for the delay. I confirmed the problem was in the tree-sitter-bash 
> >> side and submitted a PR to fix it:
> >> https://github.com/tree-sitter/tree-sitter-bash/pull/137
> >> Once my fixes are pulled in, there is no change required to my patch.
> > 
> > Do we need to wait for their fix, or can we have code that will start
> > working correctly when they fix the parser?
> 
>  We don’t need to wait for their fix. When they fix the parser and users 
> install the new parser, everything will work correctly.

Thanks, then this aspect of the patch should not delay installing the
mode.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]