Re: A few changes to test in master

[Bastien]

Hi Jack,

Jack Kamm <address@hidden> writes:

> FWIW, I wouldn't mind if this were a global minor mode, I intend to
> activate it globally with `org-table-header-line-p'.

Well, it only makes sense in org buffers, so activating it through
this variable is okay IMO.

> Since updating and testing for a few minutes, I haven't noticed this
> issue anymore. However, I have noticed a new bug, where the header line
> randomly gets "stuck" on some row of the table, so even when I scroll
> and that row is no longer on top of the buffer, that row is still
> replaced by the header line.

Yes, fixed now.

>> M-x customize-face RET org-table-header RET
>
> Thanks. The default face looks great on light-themed backgrounds like
> leuven, but is hard to read on some dark-themed backgrounds like
> tsdh-dark or zenburn, due to their light text. While this could be left
> to the user or individual themes to fix, it'd be nice if it worked out
> of the box for the common dark themes. Maybe the simplest solution would
> be to set both the background and foreground colors in the default
> face?

Sure - would you like to suggest a patch for this?

-- 
 Bastien